stdbuf: support cross-platform building#11609
Merged
Ecordonnier merged 1 commit intouutils:mainfrom Apr 11, 2026
Merged
Conversation
Co-Authored-By: 白彩恋 <169267914+shirorren@users.noreply.github.com>
|
GNU testsuite comparison: |
Collaborator
|
Can you please add a PR description and clarify the functional fix? |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
Sorry a description has now been added. |
Collaborator
|
Thanks! I was curious and checked the git history: windows -> unix cross-compilation of stdbuf has not been supported until now. It's not a recent regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes e.g. building Android targets on Windows.
Because
build.rsuses#[cfg]to determine, the suffix of the platform to be built cannot be correctly determined during cross-platform building.After changing from
#[cfg]toenv::var,feat_os_unix_android, which includesstdbuf, can be compiled normally. There is no actual test for other cross-platform compilation scenarios, but in theory it can be used normally.